Skip to content

Fixed double click bug #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehennestad merged 4 commits into from
Mar 16, 2026
Merged

Fixed double click bug #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7513d7
Fixed double click bug
jesshaley Mar 16, 2026
8ef72fe
More updates needed to function
jesshaley Mar 16, 2026
f810ae7
Merge branch 'dev' into troubleshooting-jhaley
jesshaley Mar 16, 2026
6c8d49d
Fixes to OnCellDoubleClick
jesshaley Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions code/apps/+nansen/@App/App.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1395,15 +1395,17 @@ function onMouseDoubleClickedInTable(app, ~, evt)
end

% Get name of column which was clicked
thisColumnName = app.UiMetaTableViewer.getColumnNames(thisCol);
[~,thisVariableName] = app.UiMetaTableViewer.getColumnNames(thisCol);

% Use table variable attributes to check if a double click
% callback function exists for the current table column
TVA = app.getTableVariableAttributes('HasDoubleClickFunction');

isMatch = strcmp(thisColumnName, {TVA.Name});
isMatch = strcmp(thisVariableName, {TVA.Name}) & ...
strcmp(app.UiMetaTableViewer.MetaTableType,[TVA.TableType]);

if any( isMatch )

tableVariableClassName = TVA(isMatch).ClassName;
if isempty(tableVariableClassName); return; end

Expand Down
6 changes: 4 additions & 2 deletions code/apps/+nansen/@MetaTableViewer/MetaTableViewer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,16 +524,18 @@ function setSelectedEntries(obj, IND, preventCallback)
end
end

function columnNames = getColumnNames(obj, columnIndices)
function [columnNames,variableNames] = getColumnNames(obj, columnIndices)
% getColumnNames - Get name of column(s) given column indices
if nargin < 2; columnIndices = []; end

columnNames = obj.ColumnModel.getColumnNames();
[columnNames,variableNames] = obj.ColumnModel.getColumnNames();
if ~isempty(columnIndices)
columnNames = columnNames(columnIndices);
variableNames = variableNames(columnIndices);
end
if numel(columnNames) == 1 && iscell(columnNames)
columnNames = columnNames{1};
variableNames = variableNames{1};
end
end
end
Expand Down
Loading