test: add fuzz tests for zero-duration, zero-cliff, and zero-amount v…#92
Merged
JerryIdoko merged 1 commit intoVesting-Vault:mainfrom Feb 25, 2026
Conversation
…aults Cover edge cases where duration=0, cliff=0, or amount=0 to verify no divide-by-zero panics occur and behavior matches expectations. Closes Vesting-Vault#67, closes Vesting-Vault#41
Contributor
Author
|
@JerryIdoko |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67
Summary
Adds fuzz tests ensuring the contract handles vaults with
total_duration = 0without divide-by-zero panics or crashes.Root Cause
No runtime bug exists.
vesting_contractsalready guards against zero-duration division via thenow >= vault.end_timeearly return incalculate_time_vested_amount.vesting_curvesexplicitly rejects zero duration at initialization with an assertion. However, no tests existed to verify this behavior.Fix
Added 9 edge-case tests across both contracts:
vesting_contracts(6 tests)vesting_curves(3 tests)initializeinitializeTesting
vesting_contractscompilation step