Skip to content

feat: Add pagination for vaults endpoint#23

Merged
JerryIdoko merged 4 commits intoVesting-Vault:mainfrom
jobbykings:issue-18-pagination-only
Feb 19, 2026
Merged

feat: Add pagination for vaults endpoint#23
JerryIdoko merged 4 commits intoVesting-Vault:mainfrom
jobbykings:issue-18-pagination-only

Conversation

@jobbykings
Copy link
Copy Markdown
Contributor

  • Add GET /api/vaults with page and limit query params
  • Default limit set to 20 (acceptance criteria)
  • Prevents performance issues with 1000+ vaults
  • Include pagination metadata in response
  • Add comprehensive test suite

closes #18

- Add GET /api/vaults with page and limit query params
- Default limit set to 20 (acceptance criteria)
- Prevents performance issues with 1000+ vaults
- Include pagination metadata in response
- Add comprehensive test suite

Fixes Vesting-Vault#18
- Add unit test for pagination logic
- Fix integration test with proper error handling
- Add test script to package.json
- Tests now exit with proper codes (0/1)
- Pipeline should now pass all tests

Fixes Vesting-Vault#18
@JerryIdoko JerryIdoko merged commit fa8636b into Vesting-Vault:main Feb 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#18 Issue 18: [Performance] Pagination for Vaults

2 participants