Feature/delegate claiming#30
Merged
JerryIdoko merged 3 commits intoVesting-Vault:mainfrom Feb 20, 2026
Merged
Conversation
added 3 commits
February 20, 2026 04:38
- Add propose_new_admin function for creating pending transfer proposals - Add accept_ownership function to complete transfer process - Add transfer_ownership function for backward compatibility - Add comprehensive API endpoints for admin key management - Include 24-hour expiration on pending proposals - Add full audit logging for all admin actions - Support both global and contract-specific admin transfers - Add comprehensive test suite with error handling - Prevent accidental lockout with two-step verification Resolves Vesting-Vault#16: [Admin] Update Admin Key
- Add SubSchedule model for multiple vesting schedules per vault - Implement top-up functionality with configurable cliff periods - Add comprehensive API endpoints for vault management - Update indexing service to handle vesting events - Create database migration for new tables - Add comprehensive test suite - Support independent cliffs per top-up - Implement pro-rata token release across sub-schedules Closes Vesting-Vault#19
- Add delegate_address field to Vault model - Implement setDelegate function for vault owners - Add claimAsDelegate function for delegate claiming - Create API endpoints for delegate management - Add comprehensive test suite - Update documentation Resolves Vesting-Vault#13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cd "C:\Users\USER\CascadeProjects\Vesting-Vault" ; gh pr create --title "feat: Delegate Claiming Functionality" --body "$(cat << 'EOF'
Summary
Implements delegate claiming functionality allowing beneficiaries to set a delegate address that can trigger claim functions on their behalf. This enables users to keep tokens in cold wallets for security while using hot wallets for convenient claiming operations.
Changes Made
delegate_addressfield to Vault model with proper indexingsetDelegate()function for vault owners to set delegatesclaimAsDelegate()function for delegate claiming with proper validationPOST /api/delegate/set- Set delegate for vaultPOST /api/delegate/claim- Claim tokens as delegateGET /api/delegate/:vaultAddress/info- Get vault delegate infoSecurity Features
Acceptance Criteria
set_delegate(vault_id, delegate_address)function implementedTesting
backend/test/delegateFunctionality.test.jsDocumentation
DELEGATE_CLAIMING.mdCloses #13