This repository was archived by the owner on Aug 9, 2020. It is now read-only.
Fixes incorrect activity start, when using RxAcitivtyResult inside so…#55
Open
miszmaniac wants to merge 1 commit intoVictorAlbertos:2.xfrom
Open
Fixes incorrect activity start, when using RxAcitivtyResult inside so…#55miszmaniac wants to merge 1 commit intoVictorAlbertos:2.xfrom
miszmaniac wants to merge 1 commit intoVictorAlbertos:2.xfrom
Conversation
…me of rxjava methods like andThen()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using methods like:
Completable.andThen() you can pass Observable without lambda method.
This is my example:
networkStateRepository.requireNetworkConnectedOrError() .andThen(RxActivityResult.on(activity).startIntent(...))Because another subscribe was called inside RxActivityResult it was not respecting error state from first method, which caused incorrect behavior.
After this fix, everything works as expected.