Conversation
VictorVVedtion
left a comment
There was a problem hiding this comment.
Thanks for the contribution @zamadye! Type hints are a great improvement.
One small note: dict[str, any] uses the built-in any function, not the Any type. For correct static typing it should be:
from typing import Any
def scan_project(project_path: str) -> dict[str, Any]:Or alternatively, since we target Python 3.10+, we could use dict[str, object] to avoid the import entirely.
The -> None additions for the other three functions are perfect — merging those as-is.
Could you update the any → Any (or object) and I'll merge? Otherwise I can fix it on my end. Either way, great first contribution!
|
Hey @zamadye — heads up, v0.3.0 just landed on master and it modified The type hint changes are still welcome! To update:
If you'd like, you could also add type hints to the new Let me know if you need help resolving the rebase conflict! |
|
makasih bro! 🙏 |
added return type hints to the functions that were missing them. print_scan_report, init_ouro, and install_template all return None now.
also improved the scan_project return type from dict to dict[str, any] for better type checking.
let me know if i should add more specific types!