refactor: Add type constraints to ActionHandler and ActionProcessor#11
Merged
takeshishimada merged 2 commits intomainfrom Oct 30, 2025
Merged
Conversation
Add explicit type constraints to match Feature protocol requirements, ensuring type safety and preventing common errors. Changes: - Add Sendable constraint to Action type parameter - Add AnyObject constraint to State type parameter - Add Sendable constraint to ActionResult type parameter (already present) - Update ActionExecution typealias with same constraints - Add documentation explaining the purpose of each constraint Benefits: - Prevents using value-type State (wouldn't support mutation) - Prevents using non-Sendable Actions (could cause data races) - Ensures consistency with Feature protocol requirements - Compile-time enforcement of concurrency safety This is a non-breaking change as all existing usage already satisfies these constraints through Feature protocol conformance. All tests pass (255 tests). SwiftLint clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add explicit type constraints to
ActionHandlerandActionProcessorto matchFeatureprotocol requirements, ensuring type safety and consistency across the framework.Problem
Currently,
ActionHandlerandActionProcessorlack explicit type constraints:This inconsistency:
Changes
ActionHandler.swift
Action: SendableconstraintState: AnyObjectconstraintActionProcessor.swift
ActionProcessorclassActionExecutiontypealiasType Constraints Added
Benefits
Prevents value-type State errors
Prevents non-Sendable Action data races
Ensures consistency with Feature protocol
Impact
Test Results
🤖 Generated with Claude Code