[FIX] account: fix assing journal xmlids #723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngochung207
force-pushed
the
v17_fix_account_create_journal
branch
4 times, most recently
from
f6b729c to
079f29d
Compare
ngochung207
force-pushed
the
v17_fix_account_create_journal
branch
from
079f29d to
728d2d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tkcet: https://viindoo.com/web#id=60123&cids=1&model=viin.helpdesk.ticket&view_type=form
Ticket: https://viindoo.com/web#id=59883&cids=1&menu_id=89&action=1074&active_id=60&model=viin.helpdesk.ticket&view_type=form
Đoạn code cập nhật xml_id cho các sổ nhật ký đã tồn tại ở module account, nhưng logic tìm kiếm tìm không đúng, Dẫn tới việc sửa nhầm xml_id.
Việc này dẫn tới hệ thống ghi đè thông tin sổ nhật ký theo dữ liệu từ template vào bản ghi bị gán sai xml_id, dẫn tới nhầm lẫn thông tin.
Sổ nhật ký cần tạo mới thì không được tạo vì hệ thống hiểu là đã tồn tại, sổ nhật ký đã tồn tại thì bị sửa thông tin
Sau commit:
