Changes enumeration of elements and basisfunction to consistent scheme#41
Open
VikingScientist wants to merge 11 commits intomasterfrom
Open
Changes enumeration of elements and basisfunction to consistent scheme#41VikingScientist wants to merge 11 commits intomasterfrom
VikingScientist wants to merge 11 commits intomasterfrom
Conversation
Owner
Author
|
As requested @TheBB |
Contributor
|
Wow, I didn't expect this so quickly. Will try to build the python bindings against this, at least. |
…ering knot from the local knot vectors
After basis function numbering changed, files no longer necessarily have the basis functions listed in order of ID, therefore we can't just update pointers based on file order and expect to get the right ones.
VikingScientist
force-pushed
the
enumeration
branch
from
ddf3e04 to
e7a8635
Compare
Owner
Author
|
Rebased on #42 which will be merged shortly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The element reordering as it stands is currently optional, but the basisfunction reordering is forced. This is because any call to
LRSpline::generateIDs()will overwrite the enumeration given byLRSpline::renumberBasisfunctions().generateIDs()is frequently called, for instance during write-to-file, so I couldn't find a good way around this. Let me know if you have any suggestions.Hopefully this will not break any downstream applications such as IFEM, but it is not unthinkable that it is going to since the new enumeration scheme is forced.