Skip to content

FEAT edge-case for DVHDR and DVHDR10(+)#688

Open
mindgam3s wants to merge 6 commits intoViren070:mainfrom
mindgam3s:main+dvhdr
Open

FEAT edge-case for DVHDR and DVHDR10(+)#688
mindgam3s wants to merge 6 commits intoViren070:mainfrom
mindgam3s:main+dvhdr

Conversation

@mindgam3s
Copy link

@mindgam3s mindgam3s commented Feb 5, 2026

in some streams the DV and HDR is not separated by a dot but instead is bundled together like so: filename.DVHDR10p.extension
this solves it by allowing this for both DV and HDR tags to be a valid match

@Viren070
same movie

before:
before
after:
after

Summary by CodeRabbit

Bug Fixes

  • Enhanced video metadata tag recognition to better support various naming conventions for HDR formats, Dolby Vision variants, and Atmos audio options. Improved compatibility with diverse file naming standards results in more accurate metadata extraction and recognition across a wider range of video formats and codecs.

FEAT edge-case for DVHDR and DVHDR10(+) etc

in some streams the DV and HDR is not separated by a dot but instead is bundled together like so:
`filename.DVHDR10p.extension`

this solves it by allowing this for both DV and HDR tags to be a valid match
in some streams the DV and HDR is not separated by a dot but instead is bundled together like so: filename.DVHDR10p.extension

this solves it by allowing this for both DV and HDR tags to be a valid match
FIXED leftover quantifier '?'
FIXED leftover quantifier '?'
FIXED unescaped symbol
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

Walkthrough

Regex patterns for HDR-related visual tags have been updated in the parser to optionally support "dv" prefixes and expand matching criteria for HDR10+ and DV variants, affecting how video tags are identified during parsing.

Changes

Cohort / File(s) Summary
Visual Tag Regex Updates
packages/core/src/parser/regex.ts
Modified HDR10, HDR10+, HDR, and DV regex patterns to optionally include "dv" prefixes and expanded DV matching to cover HDR-related suffixes and Atmos options, increasing flexibility in visual tag pattern recognition.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • Viren070/AIOStreams#562: Adds HLG pattern to visual tag regexes alongside existing HDR/DV patterns in the same file.

Suggested reviewers

  • Viren070

Poem

🐰 Whiskers twitching at patterns so fine,
DV and HDR dance in alignment,
Optional prefixes, suffixes galore,
Video tags matching like never before!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'FEAT edge-case for DVHDR and DVHDR10(+)' clearly and specifically describes the main change: adding support for bundled DV and HDR tags without separator dots.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@hugo9655
Copy link
Contributor

hugo9655 commented Feb 5, 2026

This is not the right way to approach this problem imo.

You could easily do the same for any two that someone has placed together, and then the patterns will become so complex it'll look silly.

The only other way (which I also dont recommend) would be to remove word boundary checks (which seems to be implemented separate from the regex patterns themselves) but that will impact other filters negatively and cause false positives.

There will always be people who format releases horribly, some cases just can't easily be addressed unfortunately.

@mindgam3s
Copy link
Author

This is not the right way to approach this problem imo.
There will always be people who format releases horribly, some cases just can't easily be addressed unfortunately.

to be honest this is quite a common naming scheme for german releases...
indicating that this is DV with HDR(10)(plus) fallback
that's how it got my attention that some streams where "incorrectly" tagged by AIOStreams.

You could easily do the same for any two that someone has placed together, and then the patterns will become so complex it'll look silly.

and I didn't create a pull request for other bundled-together tags, it was specifically for this case that happens a lot of the time in german releases.

The only other way (which I also dont recommend) would be to remove word boundary checks (which seems to be implemented separate from the regex patterns themselves) but that will impact other filters negatively and cause false positives.

which I would agree to not do. that's why I added the pattern above for this one specific case DV with HDR(10)(plus) fallback

@hugo9655
Copy link
Contributor

hugo9655 commented Feb 5, 2026

and I didn't create a pull request for other bundled-together tags, it was specifically for this case that happens a lot of the time in german releases.

It sets a precedent, that is not good.

@mindgam3s
Copy link
Author

It sets a precedent, that is not good.

cannot really agree with that, as I said it is not uncommon for german release groups to name it like this

(one of the biggest to do this as well is pmHD which is German Web Tier 01)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants