FEAT edge-case for DVHDR and DVHDR10(+)#688
Conversation
FEAT edge-case for DVHDR and DVHDR10(+) etc in some streams the DV and HDR is not separated by a dot but instead is bundled together like so: `filename.DVHDR10p.extension` this solves it by allowing this for both DV and HDR tags to be a valid match
in some streams the DV and HDR is not separated by a dot but instead is bundled together like so: filename.DVHDR10p.extension this solves it by allowing this for both DV and HDR tags to be a valid match
FIXED leftover quantifier '?'
FIXED leftover quantifier '?'
FIXED unescaped symbol
WalkthroughRegex patterns for HDR-related visual tags have been updated in the parser to optionally support "dv" prefixes and expand matching criteria for HDR10+ and DV variants, affecting how video tags are identified during parsing. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
|
This is not the right way to approach this problem imo. You could easily do the same for any two that someone has placed together, and then the patterns will become so complex it'll look silly. The only other way (which I also dont recommend) would be to remove word boundary checks (which seems to be implemented separate from the regex patterns themselves) but that will impact other filters negatively and cause false positives. There will always be people who format releases horribly, some cases just can't easily be addressed unfortunately. |
to be honest this is quite a common naming scheme for german releases...
and I didn't create a pull request for other bundled-together tags, it was specifically for this case that happens a lot of the time in german releases.
which I would agree to not do. that's why I added the pattern above for this one specific case |
It sets a precedent, that is not good. |
cannot really agree with that, as I said it is not uncommon for german release groups to name it like this (one of the biggest to do this as well is pmHD which is German Web Tier 01) |
in some streams the DV and HDR is not separated by a dot but instead is bundled together like so: filename.DVHDR10p.extension
this solves it by allowing this for both DV and HDR tags to be a valid match
@Viren070
same movie
before:


after:
Summary by CodeRabbit
Bug Fixes