Skip to content

fix: Get rid of the sel override fallback#731

Open
Crunging wants to merge 1 commit intoViren070:mainfrom
Crunging:noFallback
Open

fix: Get rid of the sel override fallback#731
Crunging wants to merge 1 commit intoViren070:mainfrom
Crunging:noFallback

Conversation

@Crunging
Copy link
Contributor

@Crunging Crunging commented Feb 13, 2026

The fallback was causing an override for Web T1 to match with Web T1, and then also check if it matched with any of the legacy names, so then it would also match with anime Web T1. I think just getting rid of the fallback is the cleanest and most bug free way to deal with this.

Summary by CodeRabbit

  • Refactor
    • Refined selector override matching to use exact-name criteria only, removing legacy name variant matching from override resolution and streamlining the matching logic.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2026

Walkthrough

The _findSelOverride function in the selector access utility has been modified to remove legacy name extraction support. The function now uses only the standard name extraction method, eliminating the fallback matching path that previously allowed overrides to match both current and legacy-extracted names. This change narrows override matching to exact-name matches only.

Changes

Cohort / File(s) Summary
Override name extraction simplification
packages/core/src/utils/sel-access.ts
Removed legacy name extraction variant from _findSelOverride, eliminating the combined match path that previously supported both standard and legacy name matching. Override matching now uses only standard name extraction.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • Viren070

Poem

🐰 Legacy paths we hop away,
Cleaner matches guide the way,
One extraction, pure and true,
Simpler logic shines right through! ✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the fallback mechanism in the sel override logic to prevent unintended legacy name matches.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant