Skip to content

fix: updated the tests to reflect new function rejects #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JohnsonChin1009 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: updated the tests to reflect new function rejects #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 18 additions & 20 deletions test/unit/acpClient.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,18 +439,16 @@ describe("AcpClient Unit Testing", () => {
json: async () => ({ error: { message: "Jobs Not Found" } }),
});

await expect(acpClient.getActiveJobs()).resolves.toThrow(AcpError);
await expect(acpClient.getActiveJobs()).resolves.toThrow(
"Jobs Not Found",
);
await expect(acpClient.getActiveJobs()).rejects.toThrow(AcpError);
await expect(acpClient.getActiveJobs()).rejects.toThrow("Jobs Not Found");
});

it("should throw AcpError when fetch fails", async () => {
global.fetch = jest.fn().mockRejectedValue(new Error("Network Error"));

await expect(acpClient.getActiveJobs()).rejects.toThrow(AcpError);
await expect(acpClient.getActiveJobs()).rejects.toThrow(
"Failed to get active jobs",
"Failed to fetch ACP jobs (network error)",
);
});
});
Expand Down Expand Up @@ -540,8 +538,8 @@ describe("AcpClient Unit Testing", () => {
json: async () => ({ error: { message: "Jobs Not Found" } }),
});

await expect(acpClient.getPendingMemoJobs()).resolves.toThrow(AcpError);
await expect(acpClient.getPendingMemoJobs()).resolves.toThrow(
await expect(acpClient.getPendingMemoJobs()).rejects.toThrow(AcpError);
await expect(acpClient.getPendingMemoJobs()).rejects.toThrow(
"Jobs Not Found",
);
});
Expand All @@ -551,7 +549,7 @@ describe("AcpClient Unit Testing", () => {

await expect(acpClient.getPendingMemoJobs()).rejects.toThrow(AcpError);
await expect(acpClient.getPendingMemoJobs()).rejects.toThrow(
"Failed to get pending memo jobs",
"Failed to fetch ACP jobs (network error)",
);
});
});
Expand Down Expand Up @@ -641,8 +639,8 @@ describe("AcpClient Unit Testing", () => {
json: async () => ({ error: { message: "Jobs Not Found" } }),
});

await expect(acpClient.getCompletedJobs()).resolves.toThrow(AcpError);
await expect(acpClient.getCompletedJobs()).resolves.toThrow(
await expect(acpClient.getCompletedJobs()).rejects.toThrow(AcpError);
await expect(acpClient.getCompletedJobs()).rejects.toThrow(
"Jobs Not Found",
);
});
Expand All @@ -652,7 +650,7 @@ describe("AcpClient Unit Testing", () => {

await expect(acpClient.getCompletedJobs()).rejects.toThrow(AcpError);
await expect(acpClient.getCompletedJobs()).rejects.toThrow(
"Failed to get completed jobs",
"Failed to fetch ACP jobs (network error)",
);
});
});
Expand Down Expand Up @@ -742,8 +740,8 @@ describe("AcpClient Unit Testing", () => {
json: async () => ({ error: { message: "Jobs Not Found" } }),
});

await expect(acpClient.getCancelledJobs()).resolves.toThrow(AcpError);
await expect(acpClient.getCancelledJobs()).resolves.toThrow(
await expect(acpClient.getCancelledJobs()).rejects.toThrow(AcpError);
await expect(acpClient.getCancelledJobs()).rejects.toThrow(
"Jobs Not Found",
);
});
Expand All @@ -753,7 +751,7 @@ describe("AcpClient Unit Testing", () => {

await expect(acpClient.getCancelledJobs()).rejects.toThrow(AcpError);
await expect(acpClient.getCancelledJobs()).rejects.toThrow(
"Failed to get cancelled jobs",
"Failed to fetch ACP jobs (network error)",
);
});
});
Expand Down Expand Up @@ -853,16 +851,16 @@ describe("AcpClient Unit Testing", () => {
json: async () => ({ error: { message: "Job Not Found" } }),
});

await expect(acpClient.getJobById(123)).resolves.toThrow(AcpError);
await expect(acpClient.getJobById(123)).resolves.toThrow("Job Not Found");
await expect(acpClient.getJobById(123)).rejects.toThrow(AcpError);
await expect(acpClient.getJobById(123)).rejects.toThrow("Job Not Found");
});

it("should throw AcpError when fetch fails", async () => {
global.fetch = jest.fn().mockRejectedValue(new Error("Network Fail"));

await expect(acpClient.getJobById(123)).rejects.toThrow(AcpError);
await expect(acpClient.getJobById(123)).rejects.toThrow(
"Failed to get job by id",
"Failed to fetch job by id (network error)",
);
});
});
Expand Down Expand Up @@ -921,8 +919,8 @@ describe("AcpClient Unit Testing", () => {
json: async () => ({ error: { message: "Memo Not Found" } }),
});

await expect(acpClient.getMemoById(123, 456)).resolves.toThrow(AcpError);
await expect(acpClient.getMemoById(123, 456)).resolves.toThrow(
await expect(acpClient.getMemoById(123, 456)).rejects.toThrow(AcpError);
await expect(acpClient.getMemoById(123, 456)).rejects.toThrow(
"Memo Not Found",
);
});
Expand All @@ -932,7 +930,7 @@ describe("AcpClient Unit Testing", () => {

await expect(acpClient.getMemoById(123, 456)).rejects.toThrow(AcpError);
await expect(acpClient.getMemoById(123, 456)).rejects.toThrow(
"Failed to get memo by id",
"Failed to fetch memo by id (network error)",
);
});
});
Expand Down
Loading