Skip to content

Vector3 rewrite#5

Open
oliverbooth wants to merge 3 commits intoVirtualParadise:developfrom
BuzzInTV:feature/vector3-rewrite
Open

Vector3 rewrite#5
oliverbooth wants to merge 3 commits intoVirtualParadise:developfrom
BuzzInTV:feature/vector3-rewrite

Conversation

@oliverbooth
Copy link
Copy Markdown
Contributor

Rewrite closely resembles .NET Vector3 struct, adding many helper methods and useful default values.

Adds helper methods and useful default values
@edwinr
Copy link
Copy Markdown
Member

edwinr commented Oct 17, 2020

The Vector3 code from .NET has an MIT license, it most likely requires attribution if this is to be included.

To be honest I think general vector math functions are outside the scope of VpNet as a library, and that it should be more minimal. If someone needs to use these features they can always use the original Vector3 struct.

I'd be more in favor of having types that say something about the purpose of the data, for example a Position or Rotation type. As it is Vector3 already does not even work for object rotations because it requires 4 floats. There's actually also no reason for everything to be a double, since the only thing in VP SDK that is actually sent across the wire as a double is an object position.

@oliverbooth
Copy link
Copy Markdown
Contributor Author

There's actually also no reason for everything to be a double, since the only thing in VP SDK that is actually sent across the wire as a double is an object position.

In that case, perhaps it would be better to simply reference System.Numerics.Vectors nuget and use that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants