Skip to content

Conversation

@apocrf
Copy link
Contributor

@apocrf apocrf commented Dec 3, 2025

Description

Implements an enhanced progress bar with ETA, multiple sub-bars, and coverage of all program stages (pulling, extracting, etc.).

Notes:

  • Still need to update docs and write a new tests for EnhancedNotifier.

  • The code could use further refactoring to follow DRY and KISS principles 😔. I plan to address this together with the docs and tests updates.

  • I also had to change the test to interpret the link as a “container path”, because the test started failing on this line in my setup:

let file1_symlink = std::fs::read_to_string(rootfs.join("app/data/file1-symlink.txt"))?;

I don’t yet understand why it fails locally; I don’t think my changes should affect this behavior.

Types of changes

  • Docs update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Test Plan

cargo clippy
cargo fmt --check
cargo test --verbose

  • Code follows the project's coding standards

  • Unit tests covering the new feature have been added

  • All existing tests pass

  • The documentation has been updated to reflect the new feature

Related issues

closes #25

@Virviil
Copy link
Owner

Virviil commented Dec 3, 2025

@apocrf Great Job!

Thank you very much!

Actually, it's a big change, i need some time to understand whats going on.

First of all - i've created multiple changes in the last few days, that probably were not properly rebased (I'm not sure, at least dependences version in this PR are downgrading).

Can you double check it??

@apocrf
Copy link
Contributor Author

apocrf commented Dec 4, 2025

Yes, sure! It seems I missed something while rebasing — I’ll try to fix it.

@Virviil Virviil force-pushed the main branch 4 times, most recently from da21769 to cb9be55 Compare December 22, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhanced Progress Reporting

2 participants