Fix handling of subtitles in long_inference_video function#30
Open
ronigoldnexar wants to merge 1 commit intoVision-CAIR:mainfrom
Open
Fix handling of subtitles in long_inference_video function#30ronigoldnexar wants to merge 1 commit intoVision-CAIR:mainfrom
ronigoldnexar wants to merge 1 commit intoVision-CAIR:mainfrom
Conversation
This commit addresses a bug in the long_inference_video function where the subtitle_paths parameter was not being correctly handled when subtitles are absent. The updated function now accepts an optional subtitle_paths parameter, defaulting to None, and checks the use_subtitles flag before attempting to access subtitle data. This ensures the function can operate without subtitles if they are not provided, preventing TypeError and enhancing the function's flexibility for video processing without mandatory subtitle information. Changes include: - Adding a default value of None to the subtitle_paths parameter. - Implementing a conditional check for the use_subtitles flag before processing subtitles. - Modifying the loop that processes video batches to handle the absence of subtitles gracefully. This fix is crucial for scenarios where subtitle data may not be available, making the inference process more robust and versatile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses a bug in the long_inference_video function where the subtitle_paths parameter was not being correctly handled when subtitles are absent. The updated function now accepts an optional subtitle_paths parameter, defaulting to None, and checks the use_subtitles flag before attempting to access subtitle data. This ensures the function can operate without subtitles if they are not provided, preventing TypeError and enhancing the function's flexibility for video processing without mandatory subtitle information.
Changes include:
This fix is crucial for scenarios where subtitle data may not be available, making the inference process more robust and versatile.