Open
Conversation
![entelligence-ai-pr-reviews[bot]](https://avatars.githubusercontent.com/in/932812?s=60&v=4){kind=small}
Comment on lines
+6
to
+29
| <mat-expansion-panel> | ||
| <mat-expansion-panel-header class="mat-row" matTooltip="Edit to run custom transformations"> | ||
| <span>Custom Transformations</span> | ||
| </mat-expansion-panel-header> | ||
| <div> | ||
| <mat-form-field class="full-width" appearance="outline" matTooltip="Specify the GCS path for custom jar" | ||
| [matTooltipPosition]="'right'"> | ||
| <mat-label>Custom JAR GCS Path</mat-label> | ||
| <input matInput placeholder="Custom JAR GCS Path" type="text" formControlName="customJarPath"/> | ||
| </mat-form-field> | ||
| <br> | ||
| <mat-form-field class="full-width" appearance="outline" matTooltip="Specify the fully classified class name" | ||
| [matTooltipPosition]="'right'"> | ||
| <mat-label>Custom Class Name</mat-label> | ||
| <input matInput placeholder="Fully Classified Class Name" type="text" formControlName="customClassName"/> | ||
| </mat-form-field> | ||
| <br> | ||
| <mat-form-field class="full-width" appearance="outline" matTooltip="Specify the custom parameter required by the JAR" | ||
| [matTooltipPosition]="'right'"> | ||
| <mat-label>Custom Parameter</mat-label> | ||
| <input matInput placeholder="Custom Parameters" type="text" formControlName="customParameter"/> | ||
| </mat-form-field> | ||
| </div> | ||
| </mat-expansion-panel> |
There was a problem hiding this comment.
The formControlName attributes are used but there's no parent <form> or <ng-form> element wrapping these form fields, which will cause Angular to throw errors.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds new constants and form fields for custom JAR configurations in the Dataflow settings, along with corresponding updates in the streaming package and related UI components.
- Added three constants (CustomJarPath, CustomClassName, CustomParameter) in /ui/src/app/app.constants.ts for custom transformation support.
- Updated /streaming/streaming.go to propagate and validate the new Dataflow custom JAR parameters.
- Extended /ui/src/app/components/dataflow-form/dataflow-form.component.ts and .html to include inputs for these fields and update localStorage.
- Introduced tests in /streaming/streaming_test.go and new streaming config verification in /webv2/web_test.go.
- Minor refactoring in /profiles/source_profile.go for consistency.
💡 (4/5) You can add custom instructions or style guidelines for the bot here!
11 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Owner
Author
There was a problem hiding this comment.
PR Summary
This PR enhances Dataflow configuration by adding support for custom JAR execution through new constants and UI elements, and integrates necessary validations in the streaming package.
- Added new constants (CustomJarPath, CustomClassName, CustomParameter) in /ui/src/app/app.constants.ts.
- Updated /streaming/streaming.go to propagate and validate custom JAR parameters.
- Extended /ui/src/app/components/dataflow-form/dataflow-form.component.ts and .html with corresponding form controls and localStorage updates.
- Minor formatting/refactoring improvements in /profiles/source_profile.go and enhanced tests in /streaming/streaming_test.go and /webv2/web_test.go.
11 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #<issue_number_goes_here>