Update tex2ngl.py to work for more types of images#3
Open
miracade wants to merge 1 commit intoVogtinator:masterfrom
Open
Update tex2ngl.py to work for more types of images#3miracade wants to merge 1 commit intoVogtinator:masterfrom
miracade wants to merge 1 commit intoVogtinator:masterfrom
Conversation
I recently found that tex2ngl currently doesn't work for images which aren't in RGB or RGBA format (for example, PNGs in indexed mode). PIL's `Image.convert()` method is an easy fix
Vogtinator
reviewed
Aug 3, 2022
| def tex2ngl(src): | ||
| """Converts src to C header containing nGL TEXTURE. Returns tuple(code, object name, tuple(w, h)).""" | ||
| img = Image.open(src) | ||
| img = Image.open(src).convert("RGBA") |
Owner
There was a problem hiding this comment.
Transparency isn't supported (yet), so just RGB might make more sense
Author
|
Make sense to me. From my testing, converting from a format with an alpha channel to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently found that tex2ngl currently doesn't work for images which aren't in RGB or RGBA format (for example, PNGs in indexed mode). PIL's
Image.convert()method is an easy fix