Rewrite traction control, stability control, and ABS with proper sensor-based implementations#38
Open
Rewrite traction control, stability control, and ABS with proper sensor-based implementations#38
Conversation
…ementations Co-authored-by: Voidless7125 <167136334+Voidless7125@users.noreply.github.com>
…tion Co-authored-by: Voidless7125 <167136334+Voidless7125@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Rewrite traction and stability control and abs
Rewrite traction control, stability control, and ABS with proper sensor-based implementations
Jun 4, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR rewrites the traction, stability, and ABS control systems to provide sensor-based adjustments for improved drive behavior and safety.
- Implements advanced traction control using motor velocity feedback and inertial sensor data.
- Updates stability control with proportional heading corrections, anti-tip protection, and yaw rate limiting.
- Redesigns ABS logic to prevent wheel lockup and modulate braking power, and adds user toggles for these systems.
Comments suppressed due to low confidence (1)
src/comptition/comptition.cpp:239
- The threshold for detecting a reverse or braking command is hard-coded. Consider defining a named constant (e.g. REVERSE_COMMAND_THRESHOLD) to improve clarity and ease future adjustments.
if (forwardVolts < -1.0) { // Reverse/braking command
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dominic Troy <167136334+Voidless7125@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completely rewrites the traction control, stability control, and ABS systems to implement proper functionality using motor velocity feedback and inertial sensor data as specified in the requirements.
🔧 What was broken
The existing implementations were fundamentally flawed:
✨ What's implemented now
Traction Control
Stability Control
InertialGyro.heading()for proportional correction during straight drivingpitch()androll()to detect excessive tilt (15° threshold)ABS (Anti-lock Braking System)
🎮 User Controls Added
🧪 Testing
Created comprehensive logic tests validating:
📊 Impact
motor.velocity(),inertial.heading(), etc.)The implementation now provides real traction control, stability control, and ABS functionality instead of placeholder code that didn't actually work.
Fixes #37.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.