Master#7
Conversation
Restructured code, splitted by classes and namespaces. Minor functonality losses.
Added possibility to make account of slow connection. Used config file for example.php
Created logger class, Added new confing: debug, Refactroed example.php a bit.
Fixed all authority rights and package names. Added nice debug trace style.
|
Dear Voronenko, |
|
@AshasTob Alexander, generally I prefer to keep it in raw php way as it is now, because it demostrates the core steps . Introducing namespaces, autoloaders etc - will make it to look like http://www.smart-jokes.org/programmer-evolution.html :) There are already plenty of composer packages implementing the same logic. Goal of this repo - is to demonstrate - that you do not need 15+ files 3rd party package to introduce OTP. |
|
@Voronenko Dear Vyacheslav, The reason I did it is that I wanted to contribute to some small project to better understand how github works. So I wanted to try out how pull requests work and to get my updates installed in real project. I am actually going soon to try creating my composer package based on your algorithm code for yii2 framework(I know that it already exists tho) just to practice. Hope you are fine with this? Thank you for review and response. I accept that you can decline this pull request. |
|
@AshasTob We can make branch , like PSR.
|
|
@Voronenko Thank you for this opportunity 👍 |
2 participants
Refactored code structure;
Improved debug functionality;
Removed unused code;
Removed redundany methods;