Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new GET listens endpoint that allows users to retrieve their listen history from ListenBrainz with optional filtering parameters.
Key changes:
- Added
listensmethod toUserClientwith support for timestamp and count filtering - Refactored the API client to use a more generic
getmethod instead ofapi_call - Added comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/overhear/clients/client.rb | Renamed api_call to get and added query parameter support |
| lib/overhear/clients/user_client.rb | Implemented listens method and updated existing methods to use new get method |
| sig/overhear.rbs | Updated type signatures to reflect API changes |
| test/test_user_client.rb | Added comprehensive test coverage for the new listens method |
Comments suppressed due to low confidence (1)
test/test_user_client.rb:24
- The parameter
_paramsshould be namedparamssince it's actually used in the method body (line 46). The underscore prefix indicates an unused parameter.
def get(_endpoint, _headers, _params = {})
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.