fix: use browser-compatible timeout type #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes type compatibility issues in the WebSocket hook to ensure it works correctly in both browser and Node.js environments. The changes address timer type mismatches and improve timeout cleanup behavior.
- Replace Node-specific
NodeJS.Timeouttype with browser-compatibleReturnType<typeof setTimeout> - Enhance timeout cleanup by setting the ref to null after clearing timers
- Add comprehensive comments explaining the cross-environment compatibility approach
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm testnpm run type-checknpm run lint:check(fails: ESLint couldn't find the config "@typescript-eslint/recommended")https://chatgpt.com/codex/tasks/task_e_6898395dfe6c83278583bf5e52ee0151