Remove ContributionResource creation button #991
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the button to create a ContributionResource from the AssetResource form. This is because ContributionResources are created as part of the asset's metadata (under the credits section) and not as a separate entity. ContributionResources are never created on their own or using a form.
ShanaLMoore
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the button to create a ContributionResource from the AssetResource form. This is because ContributionResources are created as part of the asset's metadata (under the credits section) and not as a separate entity. ContributionResources are never created on their own or using a form.
This carries along from work to get the contribution behaviors working within the asset's
Creditsection. Initially they were created to be child resources but in reality they are treated as nested metadata so the full resource functionality is not needed or desired.Note:
This appears to have a larger implications in specs... I did a preliminary check in the UI to see if anything broke, but more testing should be done before fixing specs & merging.