Skip to content

Comments

Do not resolve or reject promises while running steps in parallel#254

Merged
reillyeon merged 3 commits intomainfrom
resolve_in_parallel
Feb 13, 2025
Merged

Do not resolve or reject promises while running steps in parallel#254
reillyeon merged 3 commits intomainfrom
resolve_in_parallel

Conversation

@reillyeon
Copy link
Collaborator

@reillyeon reillyeon commented Feb 12, 2025

This change introduces a "USB task source" and updates algorithms to properly mark steps which run in parallel and queue tasks to run steps which resolve or reject a promise.

Fixed #253.


Preview | Diff

This change introduces a "USB task source" and updates algorithms to
properly mark steps which run in parallel and queue tasks to run steps
which resolve or reject a promise.

Fixed #253.
@reillyeon reillyeon requested a review from scheib February 12, 2025 01:49
Copy link
Collaborator

@scheib scheib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion

@reillyeon reillyeon merged commit 1854321 into main Feb 13, 2025
2 checks passed
@reillyeon reillyeon deleted the resolve_in_parallel branch February 13, 2025 18:59
github-actions bot added a commit that referenced this pull request Feb 13, 2025
SHA: 1854321
Reason: push, by reillyeon

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Feb 13, 2025
SHA: 1854321
Reason: push, by reillyeon

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing tasks in parallel steps in WebUSB API

2 participants