Skip to content

build(Hibernate): Remove dependency on HibernateDaoSupport and HibernateTemplate #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hirokiterashima merged 4 commits into from
Oct 3, 2025
Merged

build(Hibernate): Remove dependency on HibernateDaoSupport and HibernateTemplate #309

hirokiterashima merged 4 commits into from
Oct 3, 2025

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Sep 30, 2025 •
edited
Loading

This is part of preparing for the upgrade to Spring Boot 3, which uses Hibernate 6. HibernateDaoSupport and HibernateTemplate are deprecated, and produces a runtime error when starting up the application in Spring Boot 3.

Changes

  • Remove HibernateTemplate dependency from AbstractHibernateDao
  • Remove HibernateFlusher and HibernateDaoSupport dependency from unit tests
  • Move getCriteriaBuilder() from child classes to parent (AbstractHibernateDao)
  • Inject SessionFactory to AbstractHibernateDao
  • Child Dao classes now use the EntityManager of parent (AbstractHibernateDao)

Test

  • Re-start the WISE-API application and make sure that WISE works as before. Since this is a change in the database layer which affects many parts of WISE, just checking that the data is properly saved and retrieved in the WISE-Client application as before should be sufficient.

@hirokiterashima hirokiterashima self-assigned this Sep 30, 2025
@hirokiterashima hirokiterashima added the Code Quality Improves code quality label Sep 30, 2025
breity
breity approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hirokiterashima hirokiterashima merged commit 0d8efca into develop Oct 3, 2025
2 checks passed
@hirokiterashima hirokiterashima deleted the hibernate-dao-support-deprecation branch October 3, 2025 22:00
@hirokiterashima
Copy link
Member Author

hirokiterashima commented Dec 23, 2025

🎉 This PR is included in version 1.13.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breity breity breity approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels

Code Quality Improves code quality released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hirokiterashima @breity