Track loss vs. time and epoch, #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
davidwalter2
commented
Jan 4, 2026
davidwalter2
commented
- In the fitter callbrack, the loss is stored as function of time and epoch
- Two 1D histograms are stored, one for Loss vs. epoch, one for Time vs. epoch
- Add plotting script for plotting loss vs. time and epoch
- Support other minimizers
Closed
lucalavezzo
approved these changes
Jan 7, 2026
Collaborator
lucalavezzo
left a comment
lucalavezzo
left a comment
There was a problem hiding this comment.
Approving with small changes. Let me know if you wanna bother changing these, or if I should just merge @davidwalter2
tests/plot_epoch_loss_time.py
Outdated
| ":", | ||
| "-.", | ||
| ] | ||
| linestyles = linestyles[: len(epochs)] |
Collaborator
There was a problem hiding this comment.
Maybe something like
linestyles = [
linestyles [i % len(linestyles)]
for i in range(len(epochs))
]
to avoid weird behavior for when len(epochs) > len(linestyles)? I don't know if that's a real problem.
Collaborator
Author
There was a problem hiding this comment.
Yes makes sense
tests/plot_epoch_loss_time.py
Outdated
| loc=args.legPos, | ||
| ) | ||
|
|
||
| # plot_tools.fix_axes(ax1, fig, logy=args.logy) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.