[FR-11-1] Add return and warranty fields with calculated deadline dis…#61
Merged
YousefEltobji merged 1 commit intodevelopmentfrom Apr 2, 2026
Merged
Conversation
…play [FR-11-1] Add return and warranty fields with calculated deadline display
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Kotybamic
reviewed
Apr 2, 2026
| .select('id, name, store, purchase_date, category, price, created_at') | ||
| .select('id, name, store, purchase_date, category, price, receipt_url, return_policy_days, return_deadline, warranty_duration_months, warranty_expiration, created_at') | ||
| .order('created_at', { ascending: false }); | ||
|
|
Contributor
There was a problem hiding this comment.
Clean feature add, i like the auto-calculated deadlines from purchase date. One thing I noticed is the deadline calculation logic is the same between the create and update actions, so it might be worth putting them into a shared helper
Kotybamic
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…play
[FR-11-1] Add return and warranty fields with calculated deadline display