fix: add rate limiting to auth service endpoints#188
Open
jakebromberg wants to merge 7 commits intomainfrom
Open
fix: add rate limiting to auth service endpoints#188jakebromberg wants to merge 7 commits intomainfrom
jakebromberg wants to merge 7 commits intomainfrom
Conversation
The auth service had no rate limiting, leaving login, password reset, and anonymous sign-in vulnerable to brute-force attacks. Co-authored-by: Cursor <cursoragent@cursor.com>
jakebromberg
force-pushed
the
fix/12-auth-rate-limiting
branch
from
21f53fa to
de98620
Compare
The auth rate limiter (10 req/15 min) causes integration test failures because tests like discogs.spec.js call signInAnonymous() repeatedly. Disable the rate limiter when NODE_ENV=test or USE_MOCK_SERVICES=true, matching the pattern used by the backend's rateLimiting middleware. Also set NODE_ENV=test on the CI auth container in docker-compose so the rate limiter is skipped during integration tests.
AUTH_BYPASS is guaranteed to be set in CI, unlike NODE_ENV which may not propagate reliably through Docker. This ensures the auth service disables rate limiting during integration tests, preventing 429 errors.
The tsup env config was replacing process.env.NODE_ENV with
its build-time value ("development") in the compiled output.
This meant the runtime NODE_ENV=test set by docker-compose
had no effect, so the rate limiter was always active in CI
integration tests, causing 429 Too Many Requests failures.
Removing the env block lets process.env.NODE_ENV be read at
runtime, which is what the isTestEnv guard in app.ts expects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
express-rate-limitmiddleware to the auth service (apps/auth/app.ts), limiting auth endpoints to 10 requests per 15-minute window per IP.Test plan
tests/unit/auth/rate-limiting.test.tspasses (verifiesexpress-rate-limitimport,rateLimit()config, and middleware ordering before the auth handler)/auth/sign-in/emailmore than 10 times in 15 minutes and confirm 429 responseMade with Cursor