Skip to content

fix: change shift_covers.schedule_id from serial to integer #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakebromberg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: change shift_covers.schedule_id from serial to integer #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shared/database/src/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ export type NewShiftCover = InferInsertModel<typeof shift_covers>;
export type ShiftCover = InferSelectModel<typeof shift_covers>;
export const shift_covers = wxyc_schema.table('shift_covers', {
id: serial('id').primaryKey(),
schedule_id: serial('schedule_id')
schedule_id: integer('schedule_id')
.references(() => schedule.id)
.notNull(),
shift_timestamp: timestamp('shift_timestamp').notNull(), //Timestamp to expire cover requests
Expand Down
8 changes: 8 additions & 0 deletions tests/unit/database/schema.shift-covers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import { shift_covers } from '../../../shared/database/src/schema';

describe('shift_covers schema', () => {
it('schedule_id should not be a serial/auto-increment column', () => {
const column = shift_covers.schedule_id;
expect(column.columnType).not.toBe('PgSerial');
});
});
Loading