Open
Conversation
added 2 commits
February 25, 2026 12:57
Adds CI pipeline with four jobs: validate-token (checks NPM_TOKEN validity on PRs), build (OpenNext build with artifact upload), test (vitest), and smoke-test (wrangler pages dev health check).
The .open-next directory starts with a dot, so upload-artifact@v4 skips it by default. Setting include-hidden-files: true fixes the artifact upload and unblocks the smoke-test job.
Deploying wxyc-dj with
|
| Latest commit: |
886abdd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://da61664c.dj-site.pages.dev |
| Branch Preview URL: | https://ci-pr-checks.dj-site.pages.dev |
added 4 commits
February 26, 2026 15:12
Replace secrets.NPM_TOKEN (a manually-managed PAT) with secrets.GITHUB_TOKEN which is automatically provided to workflows and has read:packages scope for packages in the same organization.
GITHUB_TOKEN needs explicit packages:read permission to access @wxyc/shared from GitHub Packages across repos in the organization.
The previous workflow set both NODE_AUTH_TOKEN and NPM_TOKEN env vars, but actions/setup-node only reads NODE_AUTH_TOKEN when registry-url is set. Simplify to use only NODE_AUTH_TOKEN with the org-level NPM_TOKEN secret. Also add npm caching to speed up installs. Note: GITHUB_TOKEN cannot access @wxyc/shared because the package is private and does not grant repository access to dj-site. The NPM_TOKEN org secret (a PAT with read:packages) is required until the package visibility is changed or dj-site is granted access.
The project .npmrc uses ${NPM_TOKEN} for auth, which takes precedence
over the ${NODE_AUTH_TOKEN} in the setup-node temp .npmrc. Both env
vars must be set for npm to authenticate correctly.
jakebromberg
pushed a commit
that referenced
this pull request
Feb 27, 2026
The @wxyc/shared package is hosted on GitHub Packages, which requires authentication. Add registry-url and NPM_TOKEN env vars to the CI workflow, matching the pattern used in PR #224.
jakebromberg
pushed a commit
that referenced
this pull request
Feb 27, 2026
The @wxyc/shared package is hosted on GitHub Packages, which requires authentication. Add registry-url and NPM_TOKEN env vars to the CI workflow, matching the pattern used in PR #224.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.nvmrcpinning Node.js to version 22.github/workflows/ci.ymlwith four jobs:validate-token,build,test, andsmoke-testCloses #222
Test plan
validate-tokenjob runs on PR events and is skipped on push to mainbuildandtestjobs run in parallel after token validationsmoke-testdownloads the build artifact and asserts HTTP 200