refactor: consolidate artist filtering with allow_compilations parameter#46
Merged
jakebromberg merged 2 commits intomainfrom Feb 22, 2026
Merged
Conversation
jakebromberg
force-pushed
the
refactor/extract-orchestration
branch
4 times, most recently
from
7170c35 to
c51684d
Compare
jakebromberg
changed the base branch from
refactor/extract-orchestration
to
main
added 2 commits
February 22, 2026 08:57
Add allow_compilations parameter to matches_artist_or_compilation() so callers can opt out of accepting compilation artists. Use the utility in filter_results_by_artist (with allow_compilations=False) and _discogs_cross_reference (conditionally based on Discogs release type), replacing inline startswith/is_compilation_artist logic. Replace manual seen_ids merge in search_compilations_for_track with deduplicate().
jakebromberg
force-pushed
the
refactor/consolidate-artist-filtering
branch
from
835c4e0 to
9455aa6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allow_compilationsparameter tomatches_artist_or_compilation()filter_results_by_artistto use the utility (withallow_compilations=False)_discogs_cross_referencewith utility callseen_idsmerge withdeduplicate()Depends on #45 (extract orchestration)
Closes #40
Test plan
ruff checkandruff formatclean