Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds retry functionality to HTTP requests in the Projects registry API client. It implements exponential backoff with configurable retry parameters to improve resilience against transient network failures.
- Adds retry mechanism with exponential backoff for HTTP GET requests
- Updates default timeout from no timeout to 5 seconds
- Introduces configurable retry parameters (max retries, initial backoff delay)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/registry/client.rs | Implements retry logic with exponential backoff and updates HTTP client configuration |
| Cargo.toml | Adds tracing and tokio dependencies required for retry implementation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lukaisailovic
approved these changes
Sep 9, 2025
xDarksome
approved these changes
Sep 9, 2025
Member
xDarksome
left a comment
There was a problem hiding this comment.
We should use an existing solution like backoff. Non-blocking tho, we can do it later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds basic retrying to the Projects registry API and project features API client. The number of retries is set to 2 (3 total attempts) with a 5-second timeout and exponential backoff starting from 100ms.
How Has This Been Tested?
Tested in the Blockchain-API branch.
Due Diligence