This repository was archived by the owner on Sep 23, 2024. It is now read-only.
added support for older eip1271 implementations#63
Open
poocart wants to merge 1 commit intoWalletConnect:masterfrom
Open
added support for older eip1271 implementations#63poocart wants to merge 1 commit intoWalletConnect:masterfrom
poocart wants to merge 1 commit intoWalletConnect:masterfrom
Conversation
|
Deploy request for walletconnect-example pending review. Review with commit 61335b5 |
Author
|
This deployed at https://stupefied-hamilton-8cb366.netlify.app/ |
Author
|
Updated PR description: added reference to EIP1271 history that this was in proposal and has been implemented by some wallets – ethereum/EIPs@026675e#diff-5641e34a6f945196e79a576e6406eb4690ee5e34624ccedfcc8e42157e23bd06. |
Omichaelking
approved these changes
Aug 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers incompatibility between different versions of EIP1271 proposal.
Reference to EIP1271 history that this was in proposal and has been implemented by some wallets – ethereum/EIPs@026675e#diff-5641e34a6f945196e79a576e6406eb4690ee5e34624ccedfcc8e42157e23bd06.