Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pedrouid
reviewed
Dec 11, 2023
Elyniss
reviewed
Dec 11, 2023
Elyniss
reviewed
Dec 21, 2023
devceline
reviewed
Dec 21, 2023
…-specs into feat/notification-pagination-read
chris13524
commented
Dec 31, 2023
Member
Author
chris13524
left a comment
There was a problem hiding this comment.
Let's break this into 3 PRs with the first to be prioritized:
- Get notification history/pagination & removal of delete notifications
- Read/unread state, notification change events, unread notification count
- Get notification by ID
devceline
reviewed
Jan 4, 2024
chris13524
commented
Jan 4, 2024
chris13524
commented
Jan 9, 2024
3 tasks
chris13524
commented
Jan 9, 2024
chris13524
commented
Jan 10, 2024
chris13524
commented
Jan 10, 2024
Member
Author
|
This PR has been updated to only include the details required for notification history/pagination which has been successfully implemented. Remaining details have been broken out into separate PRs for future discussion: |
…-specs into feat/notification-pagination-read
flypaper0
approved these changes
Jan 22, 2024
chris13524
commented
Jan 24, 2024
chris13524
commented
Jan 24, 2024
Elyniss
approved these changes
Feb 5, 2024
bkrem
pushed a commit
that referenced
this pull request
May 23, 2024
…on-read feat: notification pagination
chris13524
added a commit
that referenced
this pull request
Jun 6, 2024
…on-read feat: notification pagination
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
This PR adds new methods to the authentication page, rather than splitting these out on the RPC methods page since this is easier to understand in one spot. A subsequent PR will consolidate both pages into one.
idfield from notificationAdds method for getting a specific notification by IDAdds method for marking a notification as readAdds method for receiving updates when a notification changes (i.e. read status changing)Adds method for counting how many unread notifications there areRemaining work:
Open questions:
notification_idthe app provided when sending the notification)?