Conversation
…ch-subscriptions chore: clarify multiple watchSubscriptions
feat: nullable url and icon
…ion.appAuthenticationKey feat: NotifyServerSubscription.appAuthenticationKey
…egistration chore: remove Push Server registration
fix: app is also updated
…ructure fix(blockchain-api): adding `json-rpc` endpoint spec and removing chain-specific rpc descriptions
3eead4a to
f349179
Compare
|
@chris13524 I added an affordance for granular image size control as discussed/added by you to the proposal doc 👍 |
| - Options: `w3m | wcm` | ||
| - Example: `st=w3m` | ||
| - `sv=`: SDK version | ||
| - Options: `${framework}-${library}-${version}` |
There was a problem hiding this comment.
We'll need to have a new format for this when we introduce the multichain refactor as it might include multiple libraries. If a user decides to use SolanaWeb3JsAdapter AND EVMWagmiAdapter then what would library have?
We could maybe include an extra query param libraries ? What would be best for analytics also cc @dnul
There was a problem hiding this comment.
From AppKit versions that support multi-chain onwards, could we do e.g. react-solanaweb3js;evmwagmi-5.0.0, where the library parameter can be a ;-separated list (or via some other separator)? Maybe will relabel to {adapters} given this.
We could maybe include an extra query param libraries ?
I suspect introducing a separate parameter will create more complicated parsing:
- need to check for the positional
libraryvalue still for implementations up to version X that havesv=as${framework}-${library}-${version} - need to check for explicit
libs=query param for implementations beyond version X, wheresv=is only${framework}-${version}
There was a problem hiding this comment.
Okay, let's not overcomplicate things. I believe the ; separated values would work (though they def look ugly 😭 ).
| All API endpoints expect the following mandatory query parameters: | ||
|
|
||
| - `st=`: SDK type | ||
| - Options: `w3m | wcm` |
| "homepage": string, | ||
| "image_id": string, | ||
| "order": number, | ||
| "mobile_link": string | null, |
There was a problem hiding this comment.
Recently we had a case in web were we needed the universal_link only, nowadays the api returns the deeplink by default, and universal_link as a fallback.
Should we consider sending both again?
https://github.com/WalletConnect/web3modal/pull/2352/files
There was a problem hiding this comment.
Yes definitely 👍 I think the API shouldn't be internalising this logic and the clients should be deciding on which one to use.
If we only want to use deep_link happy days, but it shouldn't be returning ambiguous values (sometimes deep link sometimes universal) where clients have no choice in the matter.
There was a problem hiding this comment.
something like this?
"mobile_link": {
"deep_link": string | null,
"universal_link": string | null
} | null
There was a problem hiding this comment.
Yes, I think we should basically mirror what was already the standard in Explorer API, e.g.
"mobile": {
"native": "trust://",
"universal": "https://link.trustwallet.com"
},
But we can keep the deep_link/universal_link keys and not go back to native/universal
One less difference to deal with between the response schemas that way.
Will incorporate into the new PR 👍
| "mobile_link": string | null, | ||
| "desktop_link": string | null, | ||
| "webapp_link": string | null, | ||
| "app_store": string | null, |
There was a problem hiding this comment.
If we are gonna send platform: ios|android param, should we need both app_store and play_store values in the response object? I mean, if I request platform: ios there's no point for me to have play_store URL, right?
There was a problem hiding this comment.
Good point, so:
- by default it still returns both since the
platformparam is optional - if
platformis provided we could narrow the response down to omit what isn't needed forplatform
Co-authored-by: Celine Sarafa <celinesarafa@gmail.com>
Co-authored-by: Celine Sarafa <celinesarafa@gmail.com>
Co-authored-by: Celine Sarafa <celinesarafa@gmail.com>
Co-authored-by: Celine Sarafa <celinesarafa@gmail.com>
453ade4 to
fcc664a
Compare
|
Superseded by #239 |
Context
See: https://www.notion.so/walletconnect/Web3Modal-API-v2-Proposal-a2fc6323156d49f79d8092f5c39b8cda
Scope
TODO