This repository was archived by the owner on Dec 8, 2025. It is now read-only.
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
7 tasks
devceline
reviewed
Mar 12, 2024
Contributor
devceline
left a comment
devceline
left a comment
There was a problem hiding this comment.
Looks good overall, left few comments. Also this needs a rebase
Contributor
There was a problem hiding this comment.
Can we add this to the deploy CI? If it doesn't lint it shouldn't deploy no?
Comment on lines
-77
to
+79
| src={notification.image || appLogo || '/fallback.svg'} | ||
| src={(notification.image ?? appLogo) || '/fallback.svg'} |
Contributor
There was a problem hiding this comment.
Changes like this are dangerous. What if notification.image (for any reason) is an empty string? Don't like this
| <img | ||
| className="AppNotificationsCardMobile__logo" | ||
| src={app?.metadata?.icons?.[0] || '/fallback.svg'} | ||
| src={app?.metadata.icons[0] ?? '/fallback.svg'} |
| existingIds: newFullIdsSet, | ||
| fullNotifications: unshiftedNotifications, | ||
| hasMore: topicState?.hasMore || false, | ||
| hasMore: topicState?.hasMore ?? false, |
Contributor
There was a problem hiding this comment.
Again, hasMore is a boolean. I think we should change the ?? rule. In this specific instance it won't matter but a blanket change like this is bad
chris13524
force-pushed
the
fix/test-env-vars
branch
from
c234865 to
2727131
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds eslint and prettier to CI
Attempted to fix a bunch of lints, but ended up ignoring a lot of them for sake of time. Opened an issue to carefully look at these: #473
Supersedes #389