-
Notifications
You must be signed in to change notification settings - Fork 44
docs: add wallet implementation guide for wallet_pay standard #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: rohit@reown.com <rrohitramesh710@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…n proposals Co-Authored-By: rohit@reown.com <rrohitramesh710@gmail.com>
Co-Authored-By: rohit@reown.com <rrohitramesh710@gmail.com>
Co-Authored-By: rohit@reown.com <rrohitramesh710@gmail.com>
… Solana) Co-Authored-By: rohit@reown.com <rrohitramesh710@gmail.com>
lukaisailovic
approved these changes
Oct 15, 2025
ganchoradkov
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: add wallet implementation guide for WalletConnect Pay
Summary
Adds concise wallet-side implementation documentation for WalletConnect Pay to the Payments section. This guide explains how wallets should handle payment requests that arrive in WalletConnect session proposals.
Changes:
payments/wallet-implementation.mdx(~220 lines)Technical approach:
proposal.params.requests.walletPayin session proposalsproposalRequestsResponsesarray when callingwalletkit.approveSession()Review & Testing Checklist for Human
EngineTypes.WalletPayParams,SignClientTypes, and other type references match the actual published SDK types (not just what's in the example code)eip155:1/erc20:0x...) and CAIP-10 account format (eip155:1:0x...) examples are correct and the parsing logic shown makes senseparseAsset()andtransferToken()which are intentionally left abstractNotes
chore/wallet-pay-dappbranch which may be temporary