Essence instead of Wool and minor changes #540
Conversation
mal0ki
commented
Dec 22, 2025
mal0ki
commented
- Updated BundleTask.java to allow for tags
- Removed unused import statement
- Added new task for anomaly: essences.json
- Fixed bundle related issue that caused a crash, Crash when hitting escape #539
- Deleted on of the wool jsons (anomaly task), kept one as reference
- Updated anomaly_theme_default.json as appropriate
- commented out unused essences from EssenceType.java, to only show/use the ones we actively use (and have icons for), as to not have floating ? for the anomaly essence bundle task.
Removed the wool tasks
…d it from anomaly_theme_default.json Added bundle task for only one type of essence, because figuring out how to make it pick multiple right now did not work out.
… icons for the anomaly quest.
|
Branched off of @family2015 's existing PR. |
src/main/java/com/wanderersoftherift/wotr/block/blockentity/anomaly/BundleTask.java
Outdated
Show resolved
Hide resolved
| public BundleTaskState createState(RandomSource rng) { | ||
| var task = new Object2IntOpenHashMap<Item>(); | ||
| rolls.forEach((item, count) -> task.put(item.value(), count.sample(rng))); | ||
| rolls.forEach((item, count) -> task.put(item.getRandomElement(rng).get().value(), count.sample(rng))); |
There was a problem hiding this comment.
This is not how I'd expect a tag to behave in this context. Instead of selecting one specific item I'd expect all to be an option (so specifying a tag of essences would mean every essence works for every anomaly).
Since the plan is for anomalies to have their own themes, I think it would be better to have a task per essence. Then different themes can require different essences.
There was a problem hiding this comment.
I believe we just did a minor change right now for this specifically. @immortius helped me a bit here.
The main goal here was to update so we could use essences instead of wool not make significant changes that would be more improvements, even though they are needed.
We haven't made an issue for refactoring this part of anomalies yet, so that needs to be done.
There was a problem hiding this comment.
Oh, and to answer your first point. Yes, I would be okay with any essence being used, but it sounded like that might need more of a rewrite than I was comfortable with / able to do at the moment.
So we just tapped into what was there already, as we use the tag for the essences, and it chooses on or a few.
I also made it so it chooses the ones we have icons for, which helps in general for the player right now.
Co-authored-by: ImplementsLegend <154452658+ImplementsLegend@users.noreply.github.com>
|
Split out #543 for further improvements to bundle tasks, |
|
Will update for spotless, and make sure it's up to date with main too in general. Just gotta finish off another thing in my workspace. rn |
