#457 Inconsistent selection of RNG algorithm #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
immortius
reviewed
Jan 4, 2026
src/main/java/com/wanderersoftherift/wotr/util/RandomFactoryType.java
Outdated
Show resolved
Hide resolved
src/main/java/com/wanderersoftherift/wotr/util/RandomSourceFromJavaRandom.java
Show resolved
Hide resolved
immortius
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #457
Implemented a Enum system to replace the index method of retrieving RNG algorithms, so previous calls for algorithm at index 0 now use the default algorithm and the instance where a specific algorithm was used (at index 6) is using the same algorithm but just referenced by name.
The current implementation only allows for the fallback to be the default algorithm but that can be implemented in cases where it may be more necessary.