Skip to content

Parse byUUID query parameter as a boolean #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
honkling wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Parse byUUID query parameter as a boolean #38

honkling wants to merge 2 commits into from

Conversation

@honkling
Copy link

@honkling honkling commented Mar 7, 2021

Validates that ?byUUID is true or false (stringified) and parses the value as a boolean

closes #35

@jellz
Copy link
Collaborator

jellz commented Mar 7, 2021

Why can't you just check req.query.byUUID === 'true'?

jellz
jellz reviewed Mar 7, 2021
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jellz jellz jellz left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

byUUID breaks the search even if false

2 participants

@honkling @jellz