Skip to content

Snp test #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WashingtonKK merged 3 commits into from
Oct 16, 2025
+5 −5
Merged

Snp test #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ad3461
Fix SEV-SNP attestation policy validation issue
WashingtonKK Oct 15, 2025
29651b0
Remove debug logging
WashingtonKK Oct 15, 2025
7807e38
remove debug logs
WashingtonKK Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/attestation/azure/snp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ func (a provider) Attestation(teeNonce []byte, vTpmNonce []byte) ([]byte, error)
quote.TeeAttestation = &attest.Attestation_SevSnpAttestation{
SevSnpAttestation: snpReport,
}

return proto.Marshal(quote)
}

Expand Down
4 changes: 2 additions & 2 deletions pkg/attestation/quoteprovider/sev.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (
"github.com/google/go-sev-guest/verify/trust"
"github.com/google/logger"
"github.com/ultravioletrs/cocos/pkg/attestation"
"google.golang.org/protobuf/encoding/protojson"
"google.golang.org/protobuf/proto"
)

const (
Expand Down Expand Up @@ -199,7 +199,7 @@ func FetchAttestation(reportDataSlice []byte, vmpl uint) ([]byte, error) {
quoteProto.CertificateChain.AskCert = askPem.Bytes
quoteProto.CertificateChain.ArkCert = arkPem.Bytes

result, err := protojson.Marshal(quoteProto)
result, err := proto.Marshal(quoteProto)
if err != nil {
return []byte{}, fmt.Errorf("failed to marshal quote proto: %v", err)
}
Expand Down
5 changes: 3 additions & 2 deletions pkg/attestation/vtpm/vtpm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,9 +310,10 @@ func addTEEAttestation(attestation *attest.Attestation, nonce []byte, vmpl uint)
return fmt.Errorf("failed to fetch TEE attestation report: %v", err)
}

extReport, err := abi.ReportCertsToProto(rawTeeAttestation)
extReport := &sevsnp.Attestation{}
err = proto.Unmarshal(rawTeeAttestation, extReport)
if err != nil {
return errors.Wrap(fmt.Errorf("failed to convert TEE report to proto"), err)
return errors.Wrap(fmt.Errorf("failed to unmarshal TEE report proto"), err)
}
attestation.TeeAttestation = &attest.Attestation_SevSnpAttestation{
SevSnpAttestation: extReport,
Expand Down