Removed redundant code (DRY principal) and made it more readable.#2
Open
dkocur wants to merge 1 commit intoWayinTop:masterfrom
Open
Removed redundant code (DRY principal) and made it more readable.#2dkocur wants to merge 1 commit intoWayinTop:masterfrom
dkocur wants to merge 1 commit intoWayinTop:masterfrom
Conversation
|
So much better :) thank you! |
|
Had to log in to say I love you. Product wasn't working until I made your changes and BAM! You probably saved me hours and I am forever grateful |
|
Just wondering if you could set this up for 10 to 12 sensors? Would I double the sensors to each port? ie... A0 has 2, A1 has 2 and so on? Or is something like that not possible? |
Author
|
@Grizwisky, You would want to use a multiplexer to increase the number of
sensors beyond the number of available ports on the Arduino.
…On Sun, Nov 21, 2021 at 9:35 PM Grizwisky ***@***.***> wrote:
Just wondering if you could set this up for 10 to 12 sensors? Would I
double the sensors to each port? ie... A0 has 2, A1 has 2 and so on? Or is
something like that not possible?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADVPYS6WBZGHSNBW7AVXQJ3UNG3B5ANCNFSM43EUVIYQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
TheRealBeowulf
approved these changes
Mar 9, 2022
rooty0
approved these changes
Jun 16, 2022
AlexandrNK
approved these changes
Jul 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. I've been a professional software developer for over 28 years. Recently you were kind enough to give me $5 off on this kit because one of the sensors was bad. I'd like to return the favor by providing this cleaned up and tested code.
It behaves almost exactly the same, but it is shorter and it is much easier to understand. The one functional change that I made was lowering the value used to determine whether or not to turn the pump on from 750 to 400. In my testing, the sensors would never get to 750 and therefore would never turn the pumps on.
I hope you like the changes!