fix: mock.js request method match #273
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanchun
reviewed
Dec 8, 2025
| } | ||
| // 请求以 cgiMock.prefix 开头，匹配处理 | ||
| const matchRequet = requestList.find((item) => req.path.search(item.url) !== -1); | ||
| const matchRequet = requestList.find((item) => req.path.search(item.url) !== -1 && req.method === (item.method || 'GET').toUpperCase()); |
Collaborator
There was a problem hiding this comment.
如果匹配需要带上请求method的话。正确逻辑应该是：判断item是否有method，如果有再匹配。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
Related issue (if exists):
Other information:
When using the Mock feature, requests with the same URL but different methods cannot be correctly matched because the matching is currently only done based on the request URL. For example, cgiMock({url: '/api/users', method: 'GET'}) and cgiMock({url: '/api/users', method: 'POST'}) will both attempt to match the same mock configuration, which can lead to unexpected behavior.
This change introduces method-based matching to resolve the issue, allowing for distinct mock configurations for different request methods on the same URL.