Step2 #9
Open
Step2 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delf-Lee
requested review from
NESOY,
doooyeon and
gmlwjd9405
and removed request for
NESOY and
doooyeon
NESOY
approved these changes
Jan 19, 2020
| } | ||
|
|
||
| public static Rank valueOf(int countOfMatch) { | ||
| public static Rank valueOf(int countOfMatch, boolean matchBonus) { |
Member
There was a problem hiding this comment.
matchBouns와 같은 부분에 대해 전략으로 Refactoring할 수는 없을까요?
| public String toString() { | ||
| return String.format("%d개 일치 (%,d원)", countOfMatch, winningMoney); | ||
| String note = ""; | ||
| if (this == Rank.SECOND) { |
Member
There was a problem hiding this comment.
이 부분을 다른 Object로 리팩토링할 수 없을까요?
나중에 특정 조건이 추가되면 확장될 가능성이 높아보여서 그렇습니다ㅠ
Author
There was a problem hiding this comment.
저도 출력에 관한 책임을 따로 분리할 계획을 갖고 있었습니다ㅎㅎ 다음 스탭때 구현해보도록 하죠.
| private Lotto lotto; | ||
| private LottoNumber bonusNumber; | ||
|
|
||
| public WinningLotto(Lotto lotto, LottoNumber bonusNumber) { |
Member
There was a problem hiding this comment.
WinningLotto와 BonusNumber는 종속적인 관계인가요?
|
|
||
| System.out.println("당첨 통계" + "\n" + "-------------"); | ||
| lottoStatistics.forEach(rank -> System.out.println( | ||
| /*lottoStatistics.forEach(rank -> System.out.println( |
| @Test | ||
| void noMatch() { | ||
| final Lotto userLotto = generateLotto(8, 9, 10, 11, 12, 13, 14); | ||
| assertThat(WINNING_LOTTO.match(userLotto)).isEqualTo(Rank.MISS); |
Member
There was a problem hiding this comment.
모든 케이스에 대해 테스트를 작성하는게 의미가 있을까요?
나중에 로또 넘버가 100가지 되는 경우에 대해 모든 케이스를 테스트 하기 위해선 어떻게 작성해야할까요?
doooyeon
approved these changes
Jan 19, 2020
| private final static Rank[] PRINT_ORDER_RANK = {Rank.FIFTH, Rank.FOURTH, Rank.THIRD, /*Rank.SECOND, */Rank.FIRST}; | ||
|
|
||
| private Map<Rank, Integer> getCounter(Lotto winningLotto, LottoCollection lottoCollection) { | ||
| private Map<Rank, Integer> getCounter(WinningLotto winningLotto, LottoCollection lottoCollection) { |
Member
There was a problem hiding this comment.
Map<Rank, Integer>을 추상화 하는 건 어떨까요?
Rank.RANK_COUNTER()안의 로직과 이 메서드의 로직을 책임으로 가질 수 있을 것 같아요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.