[interpreter] Syntax and validation for new instructions #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically ref.get_desc, ref.cast_desc, br_on_cast_desc, and br_on_cast_desc_fail. Also update the existing br_on_cast and br_on_cast_fail tests to account for the change to no longer require the cast output type to be a subtype of the input type.
rossberg
approved these changes
Oct 18, 2025
| (match_reftype c.types rt2 rt1) e.at | ||
| ("type mismatch on cast: type " ^ string_of_reftype rt2 ^ | ||
| " does not match " ^ string_of_reftype rt1); | ||
| ((top_of_heaptype c.types ht1) = (top_of_heaptype c.types ht2)) e.at |
There was a problem hiding this comment.
Suggested change
| ((top_of_heaptype c.types ht1) = (top_of_heaptype c.types ht2)) e.at | |
| (top_of_heaptype c.types ht1 = top_of_heaptype c.types ht2) e.at |
Similarly below.
Comment on lines
+812
to
+816
| let ut = match ut with | ||
| | Some ut -> ut | ||
| | None -> error e.at ("type without descriptor " ^ I32.to_string_u x.it) | ||
| in | ||
| let dt = deftype_of_typeuse ut in |
There was a problem hiding this comment.
Suggested change
| let ut = match ut with | |
| | Some ut -> ut | |
| | None -> error e.at ("type without descriptor " ^ I32.to_string_u x.it) | |
| in | |
| let dt = deftype_of_typeuse ut in | |
| let dt = match ut with | |
| | Some ut -> deftype_of_typeuse ut | |
| | None -> error e.at ("type without descriptor " ^ I32.to_string_u x.it) | |
| in |
| in | ||
| let DescT (_, ut', _) = expand_deftype_to_desctype (type_ c (x @@ at)) in | ||
| match ut' with | ||
| | Some ut' -> (Null, if exact then ExactHT ut' else UseHT ut') |
There was a problem hiding this comment.
Seeing this kind of pattern repeat, I wonder if it wouldn't be a more convenient factorisation if exactness was folded into UseHT as a parameter flag, similar to nullability or mutability.
| (func (result anyref) | ||
| (br_on_cast 0 eqref anyref (unreachable)) | ||
| (func (param (ref null any)) (result (ref null func)) | ||
| (block (result (ref null func)) (br_on_cast 1 (ref null any) (ref null func) (local.get 0) (unreachable))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically ref.get_desc, ref.cast_desc, br_on_cast_desc, and
br_on_cast_desc_fail. Also update the existing br_on_cast and
br_on_cast_fail tests to account for the change to no longer require
the cast output type to be a subtype of the input type.