Algorithms for bluetooth.descriptor commands #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reillyeon
requested changes
Aug 5, 2025
index.bs
Outdated
| 1. Set |params|[`"characteristicUuid"`] to |characteristic|'s <a>UUID</a>. | ||
| 1. Set |params|[`"descriptorUuid"`] to |descriptor|'s <a>UUID</a>. | ||
| 1. Set |params|[`"type"`] to |type|. | ||
| 1. If |type| is `write`, set |params|[`"data"`] to a [=new=] {{Uint8Array}} wrapping a [=new=] {{ArrayBuffer}} containing |bytes|. |
Contributor
There was a problem hiding this comment.
I missed this in the previous PR but since params isn't a WebIDL type I don't think using a Uint8Array is correct here. Isn't there a CDDL type we should be initializing for a byte array?
Contributor
Author
There was a problem hiding this comment.
Updated. Please see the latest patch.
I didn't find anything relative in CDDL spec, but I found one example in https://www.w3.org/TR/webdriver-bidi/#get-the-response-data (for how it populate headers field). I just followed it to init an empty array and populate the array with value.
reillyeon
approved these changes
Aug 5, 2025
github-actions bot
added a commit
that referenced
this pull request
Aug 5, 2025
SHA: 4706ca3 Reason: push, by chengweih001 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Aug 5, 2025
SHA: 4706ca3 Reason: push, by chengweih001 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Aug 5, 2025
SHA: 4706ca3 Reason: push, by chengweih001 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Aug 5, 2025
SHA: 4706ca3 Reason: push, by chengweih001 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete the algorithms for
bluetooth.SimulateDescriptorResponse,bluetooth.DescriptorEventGenerated, andbluetooth.simulateDescriptor.Preview | Diff