Fix/con 416 code cleanup #721
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix/con 420 grecaptcha bugfixes (#719) * move where we filter our language value, to be available for URL parameter setting. * use a getter method instead of direct property access * add some compatibility for WPML and Polylang to use currently used language code with reCAPTCHA * move tab title setting to init, to avoid textdomain errors * run field defaults setting on init to avoid textdomain issues * Fill in next release number * grabbing this from the mass cleanup ticket * Feature/con 426 get lists updates (#720) * allow for conditionally displaying the dismiss link for our notification system. * bump successful list fetch to 12hr timeframe * move failing list sync requests to be cached for a day instead of 15min. This should reduce down failure token requests * new helper method to return whether or not we have exceptions going on * show our lists notes notif * construct our new lists notes notification * variable verbage sync. * Fill in next release number * Fill in next release number * list screen already handled by is_constant_contact(), only show notif if we have the elevated exception * Fill in next release number * Revert "list screen already handled by is_constant_contact(), only show notif if we have the elevated exception" This reverts commit a1f4cb0. * add our exceptions check, but also explain why we are re-checking for current screen * Feature/con 427 pause refresh attempts (#722) * move from day-long transients to persistant option * return early from refresh_token method if we have already determined we need to manually refresh * return a little earlier in exec method on errors * new helper methods for manual disconnect/reconnect needs options * update callback that maybe shows admin notification for the manual disconnect/reconnect to use option over transient * invoke our disconnect/reconnect email upon api result failure specific to invalid_grant. update our wording and potential form ID use * upon manual disconnect, delete our maybe needs reconnected option * demote to h3 to prevent admin notices showing in our styled area; * revise messaging to indicate it could be one of multiple reasons * re-escape for sake of code cleanliness. Add in constant_contact_get_needs_manual_reconnect check to make the status show disconnected * Fill in next release number * Fill in next release number * switch order for consistency, use string parameters instead of boolean values for option storage and comparison * pass string true false instead of boolean, for option data type comparisons * explain early exit * among so many changes going on from different branches, forgot this was not a conditionally shown. It should be persistent * fill in phpdoc for new method * Constant Contact Lists updates in various connective states. (#724) * register our list post type regardless of connected status * start new link for different purposes * fix connecting issues from changes in regards to i18n moves * conditionally rework our sync link based on status of api connection * amend admin notification wording based on connected status * move out of if statements * add an aria-label for ADA compliance * fix dismiss notif logic * make sure we have the key first * npm updates * npm version updates * version bump * version bumps * update changelog
…escape some translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOT FINISHED YET