Add support to xml data type #1393
Conversation
support for XML attributes using ObjectGeneWithAttributes
arcuri82
left a comment
arcuri82
left a comment
There was a problem hiding this comment.
@suarezrominajulieta thx for your first PR! see comments
|
|
||
| when { | ||
|
|
||
| format.isCsharp() -> { |
There was a problem hiding this comment.
don't add for isCsharp(), as it is deprecated, and no longer in use (although we haven't cleaned the code to remove its occurrences)
| } | ||
|
|
||
| var gene = getGene("body", obj.schema, schemaHolder,currentSchema, referenceClassDef = null, options = options, messages = messages, examples = examples) | ||
| val deref = obj.schema.`$ref`?.let { ref -> val name = ref.substringAfterLast("/") |
There was a problem hiding this comment.
hard to read. use better indentation, eg:
val deref = obj.schema.`$ref`?.let { ref ->
val name = ref.substringAfterLast("/")
SchemaUtils.getReferenceSchema(schemaHolder, currentSchema, ref, messages)
} ?: obj.schema
also, is name variable used in this block?
| .replace("\"", """) | ||
| .replace("'", "'") | ||
|
|
||
| private fun singularize(n: String): String = |
There was a problem hiding this comment.
what is this for? also, it would not be working for irregular terms, eg, foot vs feet.
also, if really needed, should go into org.evomaster.core.utils.StringUtils
| else -> n | ||
| }.replaceFirstChar { it.uppercase() } | ||
|
|
||
| private fun unwrap(v: Any?): Any? = |
There was a problem hiding this comment.
you want to unwrap genes, need to use Gene.getLeafGene().
also if needed, generic utils on genes should be in GeneUtils
| public fun cleanXmlValueString(v: String): String = | ||
| v.removeSurrounding("\"").let(::escapeXmlSafe) | ||
|
|
||
| private fun getPrintedValue( |
| ) | ||
| ) | ||
|
|
||
| private fun isPrimitiveGene(value: Any?): Boolean = |
There was a problem hiding this comment.
what is the definition of "primitive" here? and is it something specific for XML only? many other genes could have to be included here... eg Regex, Uri, URL, and so on.
Depending on how it is used, and its definition, might need to consider to add a Gene.isPrimitive
|
|
||
| is Gene -> "<$name>${getPrintedValue(previousGenes, v, targetFormat)}</$name>" | ||
|
|
||
| else -> "<$name>${cleanXmlValueString(v.toString())}</$name>" |
There was a problem hiding this comment.
are we actually considering cases in which v is not a Gene? how would that happen? leave comment in the code if indeed it is possible
| .keys | ||
|
|
||
| if (duplicated.isNotEmpty()) { | ||
| throw IllegalStateException("Duplicate child elements not allowed in XML: $duplicated") |
There was a problem hiding this comment.
this type of checks on the state of this fields should be done at construction time as well. also depends if they are mutable. as this is info from the schema (which can have mistakes), we should not crash, but rather flags errors in RestActionBuilderV3
|
|
||
| assertEquals("{foo,bar,nested{hello}}", actual) | ||
| } | ||
|
|
There was a problem hiding this comment.
we also need E2E tests (ask @jgaleotti to show/explain you how they work):
- at least 1 white-box in
core-tests/e2e-tests/spring/spring-rest-openapi-v3 - 1 in black-box in
core-tests/e2e-tests/spring/spring-rest-bb
for example, could have API with endpoint same name but supporting incoming payload in both JSON and XML. for XML, could check some attributes are properly handled/parsed
|
thank you for the comments! I'll look into them |
3 participants
No description provided.