-
Notifications
You must be signed in to change notification settings - Fork 6
--target can point to file directly #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michael-kotliar
wants to merge
10
commits into
WeirauchLab:cwl-docker-workflow
Choose a base branch
from
michael-kotliar:cwl-docker-workflow
base: cwl-docker-workflow
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a2ada52
Add CMakeLists.txt file
michael-kotliar 84f9a24
Minor args refactor
michael-kotliar 7cccc75
Allow to set file path in --target
michael-kotliar 6921ec8
Updated Dockerfile to point to specific version
michael-kotliar 2cb7235
Unimportant changes
michael-kotliar 1952f7d
Unimportant changes
michael-kotliar 497def5
Return to one dash arguments
michael-kotliar 1cd21c6
Decreased number of layers in Dockerfile
michael-kotliar 695b68e
Add -prefix argument
michael-kotliar ec00305
Move header file to include folder
michael-kotliar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| cmake_minimum_required(VERSION 3.6) | ||
| project(RELI) | ||
|
|
||
| set(CMAKE_CXX_STANDARD 11) | ||
| find_package(GSL REQUIRED) | ||
| include_directories (include) | ||
|
|
||
| set(SOURCE_FILES | ||
| src/RELI.cpp | ||
| src/RELI_impl.cpp | ||
| include/RELI_impl.h) | ||
|
|
||
| add_executable(RELI ${SOURCE_FILES}) | ||
| target_link_libraries(RELI GSL::gsl) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,29 +1,30 @@ | ||
| # ================================================================ | ||
| # | ||
| # Dockerfile for RELI (public release) | ||
| # | ||
| # Version: 0.0.2 | ||
| # Author: Kevin Ernst <kevin.ernst -at- cchmc.org> | ||
| # Date: 25 July 2018 | ||
| # | ||
| # Build: docker build --rm -t weirauchlab/reli:v0.0.2 -f Dockerfile . | ||
| # Pull: docker pull weirauchlab/reli:v0.0.2 | ||
| # Run: docker run --rm -ti weirauchlab/reli:v0.0.2 | ||
| # | ||
| # ================================================================ | ||
|
|
||
| # start with https://store.docker.com/images/centos | ||
| FROM alpine | ||
|
|
||
| # install prerequisite development packages | ||
| RUN apk update | ||
| RUN apk add g++ make gsl gsl-dev bzip2 bash which | ||
|
|
||
| RUN mkdir -p /reli/src | ||
| WORKDIR /reli | ||
| ENV PATH $PATH:/reli | ||
|
|
||
| COPY src src/ | ||
| COPY Makefile . | ||
|
|
||
| # install prerequisite development packages | ||
| # build RELI from source | ||
| RUN make | ||
| RUN ln -s RELI reli | ||
| ENV PATH $PATH:/reli | ||
|
|
||
| # Remove unnecessary packages pulled in as dependencies of g++ | ||
| RUN apk del g++ | ||
| RUN apk add libstdc++ libgcc | ||
| RUN apk update &&\ | ||
| apk add g++ make gsl gsl-dev bzip2 bash which libstdc++ libgcc &&\ | ||
| make &&\ | ||
| ln -s RELI reli &&\ | ||
| apk del g++ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Misha, what's the purpose of this (the
Version: 0.0.2)? I like the idea of having examples for "Build," "Pull," and "Run," but I'm trying to understand why the version tag cannot simply belatest.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If our CWL file uses
latestthen after updating docker container, the inputs in CWL file should be updated too. To better control the correspondence between CWL and Docker I'd rather use more specific versions instead oflatestThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, try to rebuild Dockerfile. I guess, it should me much smaller, then the original one.