feat: improve VotingPanel accessibility with semantic attributes#24
feat: improve VotingPanel accessibility with semantic attributes#24
Conversation
- Add `type="button"` to player selection buttons to prevent form submission issues. - Add `aria-pressed` to indicate selection state to screen readers. - Add `aria-label` for clearer action description. - Document accessibility pattern in `.Jules/palette.md`. Co-authored-by: WeixuanZ <39925558+WeixuanZ@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR improves the accessibility of the
VotingPanelcomponent by adding semantic attributes to the player selection buttons.type="button"ensures buttons behave correctly in all contexts.aria-pressedcommunicates the toggle state to assistive technologies.aria-labelprovides a clear description of the button's action.This addresses a micro-UX improvement opportunity identified during exploration.
PR created automatically by Jules for task 5223349787691130736 started by @WeixuanZ