⚡ Bolt: Prevent PlayerList re-renders during voting#27
⚡ Bolt: Prevent PlayerList re-renders during voting#27
Conversation
- Wrap PlayerCard in React.memo with custom deep comparison - Stable callback for onKick to avoid breaking memoization - Optimize rendering during frequent GameState updates Co-authored-by: WeixuanZ <39925558+WeixuanZ@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Memoized
PlayerCardcomponent and refactoredPlayerListto pass stable callbacks.🎯 Why: The
GameStateobject is replaced on every update (e.g., during voting or timer ticks), causingPlayerListto re-render allPlayerCardcomponents even if their data hasn't changed. This is expensive when many players are present.📊 Impact: Reduces
PlayerCardre-renders to near zero during voting phase (only the player being voted for updates), instead of N re-renders per vote.🔬 Measurement: Verified via build and lint. Performance gain is architectural (O(1) updates vs O(N) updates for list items).
PR created automatically by Jules for task 2063228817624252590 started by @WeixuanZ